Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): delete duplicate event and error definition from TaikoL1 #17722

Merged
merged 5 commits into from
Jul 4, 2024
Merged

refactor(protocol): delete duplicate event and error definition from TaikoL1 #17722

merged 5 commits into from
Jul 4, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jul 3, 2024 •
edited
Loading

David tested it out - it seems we no longer needs to re-define the same errors and events in the calling contracts of libraries.

@dantaik dantaik marked this pull request as ready for review July 3, 2024 02:44
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jul 3, 2024 •
edited
Loading

refactor(protocol): delete duplicate event and error definition from TaikoL1

Generated at commit: 08c96d3f8c05b9b0fd227f0ac8e21ce7084c3ded

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
41
53
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik enabled auto-merge July 4, 2024 02:46
@dantaik dantaik requested review from adaki2004 and removed request for adaki2004 July 4, 2024 02:46
@dantaik dantaik requested a review from smtmfft July 4, 2024 02:54
@dantaik dantaik added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 0607b14 Jul 4, 2024
5 checks passed
@dantaik dantaik deleted the delete_dup_events_errors branch July 4, 2024 03:03
@taiko-kitty taiko-kitty mentioned this pull request Jul 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@xiaodino xiaodino xiaodino approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

@bennettyong bennettyong Awaiting requested review from bennettyong

@swarna1101 swarna1101 Awaiting requested review from swarna1101

@smtmfft smtmfft Awaiting requested review from smtmfft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dantaik @davidtaikocha @xiaodino