Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): allow TAIKO token bonds deposits and withdrawal #17725

Merged
merged 15 commits into from
Jul 4, 2024
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jul 3, 2024

This PR implements the old idea of managing in-contract token balance to avoid:

  1. resolving Taiko token address
  2. multiple balance modifications in TaikoToken contract which also reads delegates and modifies voting powers.
Screenshot 2024-07-03 at 11 35 39

///

Screenshot 2024-07-03 at 11 36 14

Copy link

openzeppelin-code bot commented Jul 3, 2024

feat(protocol): allow TAIKO token bonds deposits and withdrawal

Generated at commit: 37f7267fd58981782996bb9480b0c4a53b1fa6ca

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik marked this pull request as ready for review July 3, 2024 04:03
Copy link
Contributor

@adaki2004 adaki2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 1 remark: Even tho we are not using the batchTransfer() in protocol, but i think it is still a useful feature to the token when someone wants to batch send for whatever reason.

@dantaik
Copy link
Contributor Author

dantaik commented Jul 4, 2024

LGTM, 1 remark: Even tho we are not using the batchTransfer() in protocol, but i think it is still a useful feature to the token when someone wants to batch send for whatever reason.

Added it back.

@dantaik dantaik enabled auto-merge July 4, 2024 01:04
@dantaik dantaik disabled auto-merge July 4, 2024 01:04
@dantaik dantaik requested a review from adaki2004 July 4, 2024 01:31
@dantaik dantaik added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit e505392 Jul 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants