-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(app): tolerate partial provider failures in get_all_provider_models() #2936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tivris
wants to merge
7
commits into
tailcallhq:main
Choose a base branch
from
tivris:fix/partial-provider-failure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+56
−23
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7abf8b0
fix(app): tolerate partial provider failures in get_all_provider_mode…
tivris a01263c
[autofix.ci] apply automated fixes
autofix-ci[bot] afed37f
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] ebecca3
refactor(app): surface per-provider errors to UI callers
tivris d789f71
Merge branch 'main' into fix/partial-provider-failure
tivris 2e4df86
[autofix.ci] apply automated fixes
autofix-ci[bot] 5f11d58
[autofix.ci] apply automated fixes (attempt 2/3)
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation was recently changed. The problem was when the API key was invalid and more than one provider was activated the user would not be able to view the models of the invalid provider.
One option that I propose is - we could return a Vec of Result of models and on the UI, first show the error and then print the model selector with the models.