Skip to content

fix(executor): append newline when shell command stdout lacks trailing newline #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tusharmath merged 1 commit into from
Apr 13, 2026
Merged

fix(executor): append newline when shell command stdout lacks trailing newline #2979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions crates/forge_infra/src/executor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,21 @@ impl ForgeCommandExecutorService {
} else {
let stdout_writer = OutputPrinterWriter::stdout(self.output_printer.clone());
let stderr_writer = OutputPrinterWriter::stderr(self.output_printer.clone());
tokio::try_join!(
let result = tokio::try_join!(
child.wait(),
stream(&mut stdout_pipe, stdout_writer),
stream(&mut stderr_pipe, stderr_writer)
)?
)?;

// If the command's stdout did not end with a newline, the terminal
// cursor is left mid-line. Write a newline so that subsequent output
// (e.g. the LLM response) starts on a fresh line.
if result.1.last() != Some(&b'\n') && !result.1.is_empty() {
let _ = self.output_printer.write(b"\n");
let _ = self.output_printer.flush();
}

result
};

// Drop happens after `try_join` due to <https://github.com/tokio-rs/tokio/issues/4309>
Expand Down
Loading