This repository was archived by the owner on Dec 24, 2025. It is now read-only.
Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR makes the request_builder_hook configurable by enabling it to be passed through from WebOptions to the deno_fetch extension, addressing the TODO comment that previously indicated it wasn't being used.
- Changes the error type from
deno_core::error::AnyErrortodeno_error::JsErrorBoxin hook signatures - Removes the TODO comment and enables the
request_builder_hookto be passed from WebOptions to deno_fetch - Updates import statements to use the new error type
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/runtime_builder.rs | Updates the hook parameter type in with_web_request_builder_hook method |
| src/ext/web/options.rs | Changes the error type in WebOptions struct and updates imports |
| src/ext/web/mod.rs | Enables the request_builder_hook to be passed through to deno_fetch instead of being hardcoded to None |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes request_builder_hook configurable for https://github.com/tailor-inc/platform-core-services/issues/8902