Skip to content

cmd/tclipd: disable HTTPS and warn if enabled but unavailable #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cmd/tclipd: disable HTTPS and warn if enabled but unavailable #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ environment variables. All of them are optional.
| `-hide-funnel-users` | `HIDE_FUNNEL_USERS` | `false` | If set, don't display the username and profile picture of the user who created the paste in funneled pastes. |
| `-http-port` | `HTTP_PORT` | unset | If set, expose individual pastes on a HTTP server running on the given port. |
| `-control-url` | `TSNET_CONTROL_URL` | unset | If set, a custom control server to use, e.g. for Headscale users. |
| `-disable-https` | `DISABLE_HTTPS` | `false` | If set, disable serving on HTTPS with Serve. Useful for Headscale deployments. |
| `-disable-https` | `DISABLE_HTTPS` | `false`, becomes `true` when HTTPS is unavailable on the tailnet. | If set, disable serving on HTTPS, even if HTTPS serving is available. |
| `-enable-line-numbers` | `ENABLE_LINE_NUMBERS` | `false` | If set, enable line numbers being shown when viewing a paste. |
| `-enable-word-wrap` | `ENABLE_WORD_WRAP` | `false` | If set, allows lines to break and wrap to the following line. |

Expand Down
9 changes: 5 additions & 4 deletions cmd/tclipd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,12 +737,13 @@ func main() {
ctx := context.Background()
tclipURL, ok := lc.ExpandSNIName(ctx, *hostname)
if !ok {
log.Println("warning: HTTPS is unavailable, please check that it is enabled in the admin panel and that the hostname is configured correctly. Proceeding with only HTTP.")
*disableHTTPS = true
}

// if the user disabled HTTPS or HTTPS is unavailable
if *disableHTTPS {
tclipURL = *hostname
} else {
log.Println(tclipURL)
log.Fatal("HTTPS is not enabled in the admin panel")
}
}

ln, err := s.Listen("tcp", ":80")
Expand Down