Improve --theme() CSS function to only accept modern syntax
#15580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
feat/improve-css-functions
branch
from
3b1284b to
29c4137
Compare
Let's not allow old dot-notation, `--theme(colors.red.500)` should error. Even though we can make it works, we want to nudge people in using the new/modern syntax.
RobinMalfait
force-pushed
the
feat/improve-css-functions
branch
from
29c4137 to
3669437
Compare
philipp-spiess
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the
--theme(…)CSS function can only be used with the modern syntax. For backwards compatibility, thetheme(…)function must be used with the older dot notation.