Handle utilities with 1 keys in a JS config
#19254
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19250
When converting a JS config to a series of theme keys we special case a key of
1, treat it as if it were tuple access, and turn that into nested theme keys.This isn't 100% correct though because a user can use
1in an object instead of an array — in which case we should generate normal theme keys with a1in the variable name instead of one with a nested theme key separator (--).Because the conversion works based on key paths we need to treat a path like
colors.a.1.bas both--color-a-1-band--color-a--b. This ensures a utility liketext-a-1-bworks as expected.