-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/Maintainer Docs #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Really nice to have this kind of documentation. Especially the MacOS/Windows stuff sounds like many nights of pain to get right without a manual.
I managed to spot some inaccuracies in the meson option descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, took my sweet time with this again. There is a lot to cover, didn't touch the packaging and emscripten sections for now.
All review comments fixed! Let me know how it looks, or when you get a chance to look at the build instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation of the meson options looks good now!
Done! And I split off Packaging stuff into its own file, as-of-yet uncommitted. I still think it's useful to document it for posterity, especially around Emscripten, etc. |
* stashing changes for build/maintainer docs * more stashing * fix header names * add more TODO sections, cleanup * PR additions * move section up readme in doc * more sections and clarification * add build instructions for macOS/emscripten/Linux * move certain sections, expand emscripten * PR review * PR changes, splitting off packaging into other README * add missing line * change ASan explanation * PR changes * move openssl to optional
Split off from #311.
Good to go!