Added onStart and onShowStep callbacks #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a call to widget.onChanged when stepper is started
passing next step to the onShowStep so that it can call next step on it's own
talamaska
reviewed
Nov 19, 2024
lib/src/step.dart
Outdated
| @@ -415,6 +422,7 @@ class OnboardingStep { | |||
| showPulseAnimation.hashCode ^ | |||
| pulseInnerColor.hashCode ^ | |||
| pulseOuterColor.hashCode ^ | |||
| onShowStep.hashCode ^ | |||
talamaska
reviewed
Nov 19, 2024
lib/src/step.dart
Outdated
| @@ -292,6 +295,7 @@ class OnboardingStep { | |||
| Color? pulseInnerColor, | |||
| Color? pulseOuterColor, | |||
| TapCallback? onTapCallback, | |||
| Function(VoidCallback nextStep)? onShowStep, | |||
There was a problem hiding this comment.
I would prefer if you create a new typedef for this callback, named ShowStepCallback, I would prefer consistent naming of its argument, e.g. in TapCallback it is called "next", I would like this here to be also "next" and not "nextStep"
|
Please fix the description, onShowStep is not a void callback. |
added new typedef ShowStepCallback updated indentation
|
Also please add documentation about the new props, maybe with some example snippets in the readme. |
talamaska
reviewed
Nov 19, 2024
| @@ -35,6 +36,8 @@ class Onboarding extends StatefulWidget { | |||
| /// A callback that signal when the `Onboarding` is finished or stopped | |||
| final ValueChanged<int>? onEnd; | |||
|
|
|||
There was a problem hiding this comment.
add inline docs for the new callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a VoidCallback? onStart method to the Onboarding class. This is called by the stepper to call in the startStepper method.
I also added a VoidCallback? onShowStep to the OnboardingStep class. This is called prior to the tween animation of the step in both the startStepper method as well as the _nextStep method.