Skip to content
This repository has been archived by the owner on Sep 13, 2018. It is now read-only.

Turn the shop window into a tab #32

Merged
merged 3 commits into from
Jun 15, 2015
Merged

Turn the shop window into a tab #32

merged 3 commits into from
Jun 15, 2015

Conversation

Ablu
Copy link
Member

@Ablu Ablu commented Feb 11, 2015

Nothing fancy so far unfortunatly... But at least it now somehow integrates into the client.

Next steps: Open the inventory next to the shop when entering shop, make selling / buying nicer.

This Panel stuff is getting rather messy... that needs a cleaning too...

@bjorn
Copy link
Member

bjorn commented Feb 11, 2015

Hmm, I think the shop should not be a sliding panel. Why did you make it one?

@Ablu
Copy link
Member Author

Ablu commented Feb 11, 2015

I implemented it like discussed in #3. I think it is a good idea because it allows to view inventory and shop next to each other (allowing to sell in one window while buying in the other) while still allowing to watch your character in the center.

Why do you think it is a bad idea?

@bjorn
Copy link
Member

bjorn commented Feb 11, 2015

Ah, showing shop and inventory next to each other is of course a good idea. I just wouldn't visually represent it as a tab, because it is temporary and can't be triggered other than by talking to an NPC. So I would show it in the same place as the tab, but with its own frame instead of having it like a tab.

@Ablu
Copy link
Member Author

Ablu commented Feb 11, 2015

I thought about giving the tab icon some special background to make sure that the tab is only temporary. Would that be intuitive enough for you? If we keep it in the sidebar as tab it also allows to switch to the stats quickly to check what values you have there (or how they changed)...

I also have no idea how to visually represent a widget flying on the left over already existing tabbar...

@bjorn
Copy link
Member

bjorn commented Feb 11, 2015

Hrm, you have a point regarding accessibility.

@Ablu
Copy link
Member Author

Ablu commented Feb 11, 2015

Well I am still open for suggestions. But currently I do not understand how your idea would be better :)

Good night,

@Ablu
Copy link
Member Author

Ablu commented Mar 16, 2015

@Ablu
Copy link
Member Author

Ablu commented Mar 17, 2015

I added a patch to make the status page resizable into this branch since it would otherwise give too many conflict issues.

Erik Schilling added 3 commits June 15, 2015 16:42
Tabbing an item once reveals a button. Tabbing that one will buy one
unit of that item.
@Ablu Ablu merged commit 385273b into tales:master Jun 15, 2015
@bjorn bjorn removed the in progress label Jun 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants