Skip to content

Assignment 2#2

Open
taltalchow wants to merge 6 commits intomainfrom
assignment-2
Open

Assignment 2#2
taltalchow wants to merge 6 commits intomainfrom
assignment-2

Conversation

@taltalchow
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! Please make the following changes:

  1. Replace the hardcoded absolute paths to relative paths so that a Learning support can run the code successfully as well. For example: change "/Users/jerryluo/Desktop/DSI Assignment/python/05_src/data/assignment_2_data/inflammation_01.csv" to "../../05_src/data/assignment_2_data/inflammation_01.csv"

  2. Please refer to following thread of slack https://uoft-dsi-certificates.slack.com/archives/C08JWD6RRU3/p1747084222526419
    Changes to assignment_1.ipynb should not be included in this pull request.

@taltalchow
Copy link
Owner Author

Hello, I have done both 1 and 2. Please check, thank you:))

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comment 1 is not fixed. Review comment 2 is fixed.

@taltalchow
Copy link
Owner Author

Hello, I believe assignment 1 is no longer exists in this PR as the is only 1 file under files changed.

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You are correct. My earlier comment says that review comment 1 is not fixed. Hard coding of path needs to be fixed. Thanks.

@taltalchow
Copy link
Owner Author

I already replaced the path to relative path, pls check, thank you so much.

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still seeing hard coded path. Could you please check? I am attaching a screenshot
Screenshot 2025-05-15 202201

@taltalchow
Copy link
Owner Author

I've tried to save and push it one more time, are you able to see?:(

@anjali-deshpande-hub
Copy link

Hello Cheuk Tung,
Unfortunately I am still seeing the error. You can always check if the file got updated by going through the

'Code' tab at the top -> choosing 'assignment-2' branch from drop down -> navigate to 'assignments' directory and load assignment_2.ipynb file.

https://github.com/taltalchow/python/blob/assignment-2/02_activities/assignments/assignment_2.ipynb

@taltalchow
Copy link
Owner Author

Hello, I went through 'Code' tab at the top -> choosing 'assignment-2' branch from drop down -> navigate to 'assignments' directory and load assignment_2.ipynb file and I'm seeing the relative path. As shown under this screenshot.

截屏2025-05-25 下午11 12 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants