Conversation
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Look good! Please make the following changes:
-
Replace the hardcoded absolute paths to relative paths so that a Learning support can run the code successfully as well. For example: change
"/Users/jerryluo/Desktop/DSI Assignment/python/05_src/data/assignment_2_data/inflammation_01.csv"to"../../05_src/data/assignment_2_data/inflammation_01.csv" -
Please refer to following thread of slack https://uoft-dsi-certificates.slack.com/archives/C08JWD6RRU3/p1747084222526419
Changes to assignment_1.ipynb should not be included in this pull request.
|
Hello, I have done both 1 and 2. Please check, thank you:)) |
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Review comment 1 is not fixed. Review comment 2 is fixed.
|
Hello, I believe assignment 1 is no longer exists in this PR as the is only 1 file under files changed. |
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Yes. You are correct. My earlier comment says that review comment 1 is not fixed. Hard coding of path needs to be fixed. Thanks.
|
I already replaced the path to relative path, pls check, thank you so much. |
|
I've tried to save and push it one more time, are you able to see?:( |
|
Hello Cheuk Tung, 'Code' tab at the top -> choosing 'assignment-2' branch from drop down -> navigate to 'assignments' directory and load assignment_2.ipynb file. https://github.com/taltalchow/python/blob/assignment-2/02_activities/assignments/assignment_2.ipynb |


What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist