MAster to develop latest changes

.dependency-cruiser.js

@@ -4,11 +4,84 @@ module.exports = {
   forbidden: [
     {
       name: 'no-circular',
-      severity: 'info',
+      severity: 'error',
       comment:
         'This dependency is part of a circular relationship. You might want to revise ' +
         'your solution (i.e. use dependency inversion, make sure the modules have a single responsibility) ',
-      from: {},
+      from: {
+        pathNot: [
+          // TODO: remove these
+          'packages/canvas-rce/es/rce/plugins/instructure_rce_external_tools/components/ExternalToolDialog/ExternalToolDialog.js',
+          'packages/canvas-rce/es/rce/plugins/instructure_rce_external_tools/dialog-helper.js',
+          'packages/canvas-rce/es/rce/plugins/instructure_rce_external_tools/ExternalToolsEnv.js',
+          'packages/canvas-rce/es/rce/plugins/instructure_rce_external_tools/lti11-content-items/RceLti11ContentItem.js',
+          'packages/canvas-rce/es/rce/plugins/instructure_rce_external_tools/lti13-content-items/models/ResourceLinkContentItem.js',
+          'packages/canvas-rce/es/rce/plugins/instructure_rce_external_tools/lti13-content-items/processEditorContentItems.js',
+          'packages/canvas-rce/es/rce/plugins/instructure_rce_external_tools/lti13-content-items/rceLti13ContentItemFromJson.js',
+          'packages/canvas-rce/es/rce/plugins/instructure_rce_external_tools/RceToolWrapper.js',
+          'packages/canvas-rce/es/rce/RCEWrapper.js',
+          'packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/components/ExternalToolDialog/ExternalToolDialog.tsx',
+          'packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/components/ExternalToolSelectionDialog/ExternalToolSelectionDialog.tsx',
+          'packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/dialog-helper.tsx',
+          'packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/ExternalToolsEnv.ts',
+          'packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/lti11-content-items/RceLti11ContentItem.tsx',
+          'packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/lti13-content-items/models/ResourceLinkContentItem.ts',
+          'packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/lti13-content-items/processEditorContentItems.ts',
+          'packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/lti13-content-items/rceLti13ContentItemFromJson.ts',
+          'packages/canvas-rce/src/rce/plugins/instructure_rce_external_tools/RceToolWrapper.ts',
+          'packages/canvas-rce/src/rce/RCEWrapper.jsx',
+          'ui/features/course_paces/react/actions/course_paces.ts',
+          'ui/features/course_paces/react/actions/pace_contexts.ts',
+          'ui/features/course_paces/react/actions/ui.ts',
+          'ui/features/course_paces/react/api/blackout_dates_api.ts',
+          'ui/features/course_paces/react/reducers/course_paces.ts',
+          'ui/features/course_paces/react/reducers/original.ts',
+          'ui/features/course_paces/react/shared/actions/blackout_dates.ts',
+          'ui/features/course_paces/react/shared/reducers/blackout_dates.ts',
+          'ui/features/enhanced_individual_gradebook/react/components/GradingResults/CheckpointGradeInputs.tsx',
+          'ui/features/enhanced_individual_gradebook/react/components/GradingResults/DefaultGradeInput.tsx',
+          'ui/features/enhanced_individual_gradebook/react/components/GradingResults/index.tsx',
+          'ui/features/enhanced_individual_gradebook/react/components/GradingResults/SubmissionDetailModal.tsx',
+          'ui/features/enhanced_individual_gradebook/react/components/LearningMasteryTabsView.tsx',
+          'ui/features/enhanced_individual_gradebook/react/components/OutcomeInformation/index.tsx',
+          'ui/features/enhanced_individual_gradebook/react/hooks/useSubmitScore.tsx',
+          'ui/features/enhanced_individual_gradebook/utils/gradebookUtils.ts',
+          'ui/features/enhanced_individual_gradebook/utils/gradeInputUtils.ts',
+          'ui/features/gradebook/react/default_gradebook/components/GradebookGrid.tsx',
+          'ui/features/gradebook/react/default_gradebook/components/InputsForCheckpoints.tsx',
+          'ui/features/gradebook/react/default_gradebook/components/SubmissionTray.tsx',
+          'ui/features/gradebook/react/default_gradebook/Gradebook.tsx',
+          'ui/features/gradebook/react/default_gradebook/GradebookGrid/formatters/AssignmentGroupCellFormatter.ts',
+          'ui/features/gradebook/react/default_gradebook/GradebookGrid/formatters/CellFormatterFactory.ts',
+          'ui/features/lti_registrations/manage/lti_1p3_registration_form/Lti1p3RegistrationOverlayState.ts',
+          'ui/features/lti_registrations/manage/lti_1p3_registration_form/Lti1p3RegistrationOverlayStateHelpers.ts',
+          'ui/features/speed_grader/react/SpeedGraderCheckpoints/SpeedGraderCheckpoint.tsx',
+          'ui/features/speed_grader/react/SpeedGraderCheckpoints/SpeedGraderCheckpointsContainer.tsx',
+          'ui/shared/assignments/react/AssignmentHeader.tsx',
+          'ui/shared/assignments/react/OptionsMenu.tsx',
+          'ui/shared/block-editor/react/assets/globalTemplates/index.ts',
+          'ui/shared/block-editor/react/components/user/blocks/IconBlock/IconBlock.tsx',
+          'ui/shared/block-editor/react/components/user/blocks/IconBlock/IconBlockToolbar.tsx',
+          'ui/shared/block-editor/react/components/user/blocks/IconBlock/index.ts',
+          'ui/shared/block-editor/react/components/user/common/IconPopup.tsx',
+          'ui/shared/block-editor/react/utils/getTemplates.tsx',
+          'ui/shared/block-editor/react/utils/index.ts',
+          'ui/shared/context-modules/differentiated-modules/react/Item/ItemAssignToTray.tsx',
+          'ui/shared/context-modules/differentiated-modules/react/Item/ItemAssignToTrayContent.tsx',
+          'ui/shared/context-modules/react/ContextModulesPublishIcon.tsx',
+          'ui/shared/context-modules/utils/publishOneModuleHelper.tsx',
+          'ui/shared/files/backbone/models/Folder.js',
+          'ui/shared/files/react/modules/filesEnv.js',
+          'ui/shared/lti/jquery/messages.ts',
+          'ui/shared/lti/jquery/subjects/lti.resourceImported.ts',
+          'ui/shared/lti/jquery/subjects/requestFullWindowLaunch.ts',
+          'ui/shared/mediaelement/index.js',
+          'ui/shared/mediaelement/mep-feature-tracks-instructure.jsx',
+          'ui/shared/mediaelement/UploadMediaTrackForm.jsx',
+          'ui/shared/temporary-enrollment/react/EnrollmentTreeGroup.tsx',
+          'ui/shared/temporary-enrollment/react/EnrollmentTreeItem.tsx',
+        ],
+      },
       to: {
         circular: true,
       },
@@ -96,7 +169,9 @@ module.exports = {
         "This module depends on a module that cannot be found ('resolved to disk'). If it's an npm " +
         'module: add it to your package.json. In all other cases you likely already know what to do.',
       severity: 'error',
-      from: {},
+      from: {
+        pathNot: ['ui/shared/datetime/__tests__/momentSpec.js'],
+      },
       to: {
         couldNotResolve: true,
       },
@@ -218,11 +293,17 @@ module.exports = {
   ],
   options: {
     doNotFollow: {
-      path: ['node_modules'],
+      path: [
+        'node_modules',
+        // when we no longer import from /es/ build dirs
+        // '/es/'
+      ],
     },
 
     includeOnly: ['ui', 'packages'],
 
+    exclude: ['ui/shared/datetime/__tests__/momentSpec.js'],
+
     /* false (the default): ignore dependencies that only exist before typescript-to-javascript compilation
        true: also detect dependencies that only exist before typescript-to-javascript compilation
        "specify": for each dependency identify whether it only exists before compilation or also after
@@ -261,7 +342,7 @@ module.exports = {
          up the most expensive step in dependency cruising (module resolution)
           quite a bit.
        */
-      extensions: [".js", ".jsx", ".ts", ".tsx", ".d.ts"],
+      extensions: ['.js', '.jsx', '.ts', '.tsx', '.d.ts'],
 
       /* What to consider a 'main' field in package.json */
       // if you migrate to ESM (or are in an ESM environment already) you will want to

.dockerignore

@@ -30,6 +30,8 @@ public/dist/
 public/doc/
 public/javascripts/translations/
 !public/javascripts/translations/en.json
+log/
+!log/.keep
 tmp/*
 vendor/bundle/
 vendor/*/.git