-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] method based deployment #50
Open
tamagokun
wants to merge
10
commits into
master
Choose a base branch
from
deploy_method
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Heroku deployments Pomander needs to be able to trigger a heroku task after composer installs all of its deps: This can probably be achieved by means of a Composer plugin: https://getcomposer.org/doc/articles/plugins.md After the plugin is loaded, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather large re-vamp of how deployment stacks are built.
Not ready
Deployments with Pomander have a strict release/no-release structure with some options one of which being
scm
to help offer a more flexible means to deploy for all projects. Problem is there is no way to break out of this structure and create deployment paths for other things (i.e. Heroku, Docker)This new way allows that to happen..
All deployment related tasks are driven by a
Method
object. The method ultimately controls exactly how a deployment works. The base Method class implements the standard release / no-release structure for deploying, rolling back, cleanup, finalize, etc. There are stubbed methods forsetup_code
andupdate_code
that you can sub class and customize to your needs, or just implement all new methods.Breaking changes:
This release will introduce some potential breaking changes for anyone that used the
$app->env->scm
object. That object is now replaced by method.[ ] - Heroku method(later)