Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cargo.toml support #690

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

kurtbuilds
Copy link

Created this to start progress on supporting better autocompletion for Cargo.toml files. Specifically:

  • Autocomplete packages. My goal is to autocomplete based on a static list, the local package cache, and the crates api, falling back to only (2) when offline.
  • Autocomplete package features
  • Autocomplete package version
  • Provide code actions like "Expand dependency specification"

All cargo.toml functionality is gated behind a cargo_toml feature.

By special casing cargo support, we solve existing bugs, most notably zed-industries/zed#15261 .

Credit to @frederik-uni and @washanhanzi for prior art in this space. Having this merged into taplo will improve the new user experience for users (more discoverable than installing 2 toml LSPs), so I think it makes sense to focus all efforts into taplo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant