Skip to content

Fix wrong json file name#60

Open
richardissuperman wants to merge 1 commit intotancheng:masterfrom
richardissuperman:naming_fix
Open

Fix wrong json file name#60
richardissuperman wants to merge 1 commit intotancheng:masterfrom
richardissuperman:naming_fix

Conversation

@richardissuperman
Copy link
Copy Markdown

gui was using paramCGRA.json.

gui was using paramCGRA.json.
@tancheng
Copy link
Copy Markdown
Owner

tancheng commented Aug 11, 2025

Hi @MeowMJ and @yuqisun, IIRC, we switch param.json with paramCGRA.json at many places multiple times (e.g., here). Plz approve this PR if you think this change is okay. Thanks!

Shouldn't we align with param.json across all tools/stacks?

}

ifstream paramCGRA("./param.json");
ifstream paramCGRA("./paramCGRA.json");
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, can we just align with param.json?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so.

Copy link
Copy Markdown
Collaborator

@MeowMJ MeowMJ Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the paramCGRA.json used in CGRA-Mapper may be a little confused.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardissuperman can we try to use param.json inside the gui?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have done this in UI side as mentioned in #52 but still mapping issue so didn't check in yet, Qing can try from your side also.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuqisun sorry im a bit confused, what is the ultimate goal here ? param.json or paramCGRA.json ?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuqisun @richardissuperman plz align with param.json

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we can do this in GUI side directly in case causing issue in MM's mapper script. WDYT @richardissuperman ?

@tancheng tancheng self-requested a review August 11, 2025 00:31
MeowMJ pushed a commit to MeowMJ/CGRA-Mapper that referenced this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants