Repository navigation
Conversation
…rameter templates
This was referenced Oct 27, 2026
wdunn001
force-pushed
the
feat-variant-note
branch
from
October 27, 2026 16:59
8e49d98 to
49beabe
Compare
This was referenced Oct 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #132 (the only new commit is 8e49d98).
What this adds
variant.set_note, one engine command that replaces the description note of a named assembly variant, or clears it when the note is null or omitted. Notes could previously only be attached at variant creation, so a stale description was permanent.Details
Verification
cargo xtask cigreen: fmt, clippy-D warningsall targets, full workspace tests, wasm32 check. New engine test covers replace, null/empty clear, undo, oversized refusal and unknown-name refusal. Measuredtools/listreturns 228 tools includingvariant.set_note.