Skip to content

Preserve material when a manifold union fills a cavity - #136

Open
CC-David-CC wants to merge 2 commits into
tangency-labs:mainfrom
CC-David-CC:fix/retain-material-on-cavity-fill
Open

CC-David-CC wants to merge 2 commits into
tangency-labs:mainfrom
CC-David-CC:fix/retain-material-on-cavity-fill

Conversation

@CC-David-CC

Copy link
Copy Markdown

Filling a hollow 10 mm cube can return zero volume when the hollow body is the first operand. The expected volume is 1000 mm³.

Preserve the material region when ordinary manifold union removes an internal face between finite regions without merge ancestry. The regression covers exact and enclosing fills in both operand orders.

The focused Linux test fails on 8eac63c and passes with the fix.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0723c603-168e-4a48-80e8-2814f539f842
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@CC-David-CC

Copy link
Copy Markdown
Author

super cool guys. thanks for all your awesome work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant