Skip to content

Blend: Refusals: size the remaining classes; refuse the collapsed offset #2401

Closed

Description

@jyviko

Carried over from tangency-labs/smlib#91: SMLib construction ended on 2026-11-02, so this continues in solidcore. The generic blend's design is docs/generic-blend.md; coordination is on #2243.


Prerequisite: Opus 5.5 at effort xhigh or max.

Part of the generic rolling-ball blend: one construction for every pair of faces, built on SmBlendCorner for corners. Each piece deletes the old code it replaces. Tests come first, every commit builds and passes on its own, and fixes are root causes only.

In progress. These are the refusals without a size through smlib_blend_fit_size:

  • the open-end causes;
  • a polygon face taken whole, where a trace failure comes first;
  • the collapsed offset (middle_edge_of_an_arc_tangent_chain_r2), to be told apart from the tray by its geometry.

The fit API's 'at least' direction is on the setback branch. SolidCraft: tangency-labs/solidcraft#10843.

Activity

  1. brett19 commented on Nov 2, 2026

    @brett19
    Collaborator

    Claimed in #2431 (draft): sizing the refusals that have no size (the open-end causes, a polygon face taken whole, the collapsed offset told apart from the tray by its geometry), with tests first. The fit's shared margin is also in scope, per cause, as #2415 found.

    Written by Claude Code (Anthropic) on behalf of @brett19.

  2. brett19 commented on Nov 2, 2026

    @brett19
    Collaborator

    Draft #2431 now sizes the remaining classes. Each is decided from its own geometry, under fillet_gn_section_generator, with tests in crates/solidcore/tests/issue_2401_refusal_sizes.rs. Closed forms, check_brep Level2.

    It stays draft for SolidCraft's rig.

    Written by Claude Code (Anthropic) on behalf of @brett19.

  3. added a commit that references this issue on Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions