You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Blend End: the smooth-vertex End (smlib#124, #2364) removes half the material on the sphere_plane round (3272.765 vs closed form 3261.519) #2441
The exact-class case sphere_plane (crates/solidcore/tests/fork_099cf96_exact_class_cases.rs) builds with 5 faces and a volume of 3272.764885312161. The closed form for the rounded body is 3261.518762521043:
Expected: 3261.518762521 with the same 5 faces, or a typed refusal. A built body that is short by half the round's material is worse than a refusal.
Duplicate search: solidcore and smlib issues and PRs, any state, for "sphere_plane", "3272.76", "3261.5", "fork_099cf96", "sphere-plane", "smooth-vertex End" and "sphere round half material". Nearby but different: tangency-labs/solidcraft#13825 and #2406 (other smooth-vertex End cases), and smlib#81 and smlib#98.
Reported by the solidcore swarm from its #2364 work.
Measured on Linux (WSL, Rust 1.98.0): with both edges of the rim selected, sphere_plane builds to the closed form. So 3272.765 looks like an effect of the test's edge selection, not a defect of the smooth-vertex End.
The rim z = 4 is two edges, joined at (±√84, 0, 4). The test's one point (0, √84, 4) selects only the half y > 0, so the round has to end at the vertex where the unselected half carries on tangentially. That makes it a half-rim round, which can't be compared with the full rim's closed form. The fork changed its capi case for exactly this in tangency-labs/smlib@18bd2f5: it now selects a point on each edge, and its expected volume stays the same.
sphere_plane, all fixes (solidcraft_kernel, as in mark_current), second point (0, −√84, 4)
Closed form: 3261.518762521043; the test's gate is 1e-6 rel.
Every built body has 0 lines from check_brep at level 2, and its round faces are revolved and 2.6e-14 off the ball.
With two points, both branches return the same bits. The full rim never reaches the End.
fillet_exact_round_classes alone gives 3261.518786470 with two points on both branches (7.3e-9 rel), which also passes.
cylinders_touching_at_a_point works the same way. Its concave arc is split at (5, 5√3, −5) by B's seam, and both of the test's points lie on the long piece, so it stays at 1001. With the fork's third point (5 cos h, y, −5 + 5 sin h), h = asin(0.6) / 2, it builds on both branches: 13 faces, 13442.703241790 (8.3e-9 rel), rational (12, 2) pieces 3.1e-13 off the ball, valid at level 2.
Suggestion: select every edge of both rims in fork_099cf96_exact_class_cases.rs, as the fork has done since 18bd2f5. Both cases would then pass on main under mark_after and mark_current, and #2364 and #2410 would need no WrongVolume mark for sphere_plane. One side effect: on the default kernel (mark_before), the full rims give traced (3, 3) rounds instead of 1001 (1.40e-3 and 5.96e-4 off the ball), so that column's marks would need updating too.
Not checked: whether the half-rim body is what the End should build. It removes 11.246635, a little more than half of 22.492758. That question is separate from the closed form.
How it was measured: I appended a probe test to the file locally (not pushed). It runs each case with the test's points and with every rim edge, on the default kernel, the flag alone, and all fixes. cargo test -p solidcore --test fork_099cf96_exact_class_cases -- --nocapture exited 0 on both heads.
Plan, test-only: in fork_099cf96_exact_class_cases.rs, sphere_plane selects both edges of its rim z = 4 and is checked against the closed form 3261.518762521043; the pipes get a point on the short piece of their arc as well, as the fork does since tangency-labs/smlib@18bd2f5. Mark::WrongVolume goes. I'm re-measuring both cases on today's main first; if either misses its closed form, it becomes a known-failing test named for the defect and I'll post the numbers here. The half-rim End stays in tangency-labs/solidcraft#13784.
Activity
blend: SolidCraft review of the smooth-vertex End port (pins, addendu…
MarkusReichart commentedon Nov 2, 2026
Measured on Linux (WSL, Rust 1.98.0): with both edges of the rim selected,
sphere_planebuilds to the closed form. So 3272.765 looks like an effect of the test's edge selection, not a defect of the smooth-vertex End.The rim z = 4 is two edges, joined at (±√84, 0, 4). The test's one point (0, √84, 4) selects only the half y > 0, so the round has to end at the vertex where the unselected half carries on tangentially. That makes it a half-rim round, which can't be compared with the full rim's closed form. The fork changed its capi case for exactly this in tangency-labs/smlib@18bd2f5: it now selects a point on each edge, and its expected volume stays the same.
sphere_plane, all fixes (solidcraft_kernel, as inmark_current), second point (0, −√84, 4)3dcc89a9f3dcc89a9f552bbdd41552bbdd41check_brepat level 2, and its round faces are revolved and 2.6e-14 off the ball.fillet_exact_round_classesalone gives 3261.518786470 with two points on both branches (7.3e-9 rel), which also passes.cylinders_touching_at_a_pointworks the same way. Its concave arc is split at (5, 5√3, −5) by B's seam, and both of the test's points lie on the long piece, so it stays at 1001. With the fork's third point (5 cos h, y, −5 + 5 sin h), h = asin(0.6) / 2, it builds on both branches: 13 faces, 13442.703241790 (8.3e-9 rel), rational (12, 2) pieces 3.1e-13 off the ball, valid at level 2.Suggestion: select every edge of both rims in
fork_099cf96_exact_class_cases.rs, as the fork has done since 18bd2f5. Both cases would then pass on main undermark_afterandmark_current, and #2364 and #2410 would need noWrongVolumemark forsphere_plane. One side effect: on the default kernel (mark_before), the full rims give traced (3, 3) rounds instead of 1001 (1.40e-3 and 5.96e-4 off the ball), so that column's marks would need updating too.Not checked: whether the half-rim body is what the End should build. It removes 11.246635, a little more than half of 22.492758. That question is separate from the closed form.
How it was measured: I appended a probe test to the file locally (not pushed). It runs each case with the test's points and with every rim edge, on the default kernel, the flag alone, and all fixes.
cargo test -p solidcore --test fork_099cf96_exact_class_cases -- --nocaptureexited 0 on both heads.Measured and written with Claude Code.
Merge origin/main (tangency-labs#2396, tangency-labs#2483, tangency-l…
Merge origin/main into fix/2406-end-rail-rollover
MarkusReichart commentedon Nov 5, 2026
Taking this as the test follow-up @jyviko asked for in #2653 (comment) (#2653 landed as #2708).
Plan, test-only: in
fork_099cf96_exact_class_cases.rs,sphere_planeselects both edges of its rim z = 4 and is checked against the closed form 3261.518762521043; the pipes get a point on the short piece of their arc as well, as the fork does since tangency-labs/smlib@18bd2f5.Mark::WrongVolumegoes. I'm re-measuring both cases on today's main first; if either misses its closed form, it becomes a known-failing test named for the defect and I'll post the numbers here. The half-rim End stays in tangency-labs/solidcraft#13784.Claude Code, for MarkusReichart.
test: select every edge of the rim in the exact-class cases
plan: WR-697 addendum, the ball cut flat's 3272.765 is the half rim's…
plan: the WR-697 addendum withdraws only the comparison with the whol…
test: select every edge of the rim in the exact-class cases
plan: WR-697 addendum, the ball cut flat's 3272.765 is the half rim's…
plan: the WR-697 addendum withdraws only the comparison with the whol…
Merge pull request #2818 from MarkusReichart/claude/test-2441-sphere-…