Skip to content

Solidcore-only blend fix: an End's rail rolls over a tangent edge before a smooth vertex (fillet_blend_corner, WR-697 addendum) #2446

Closed

Description

@brett19

Tracking issue so this fix is not implemented twice, here and in the fork.

Problem. A round that ends at a smooth vertex (the fork's smooth-vertex End, smlib#124) is refused, SMLIB_ERR_NO_ROOM with no size, when its rail rolls over a tangent edge onto the next face before the End's plane. Example: SolidCraft #851's plate, the middle edge between the R2 front round and the R21 corner wall rounded alone at r (#2406, from tangency-labs/smlib#98). At the top vertex the rail on the R2 round reaches the round's tangent edge with the top face at the angle asin(2/(21+r)) about the wall's axis, short of the End's plane at asin(2/21), for every r > 0. The fork refuses it at SmBlendCorner::CalcEndCapEdges (SmBlendCornerEnd.cpp, 18e96f1).

Flag. UpstreamFixes::fillet_blend_corner (off by default; no new flag). PR #2410 (draft, stacked on #2364). Code: crates/solidcore/src/blend/blend_corner/end.rs (end_awaits_rollover, the cap edge on the side face's own edge), fillet_solver/p2.rs (a tangent side edge whose faces' normals agree rolls over, whatever its convexity), fillet_solver/p5/recovery.rs (the re-traced first/last piece adjusts its End corner: traced through the End's section, rail ends found again on P), fillet_geom/p3.rs (re_calc_fillet_geom_through). Record: plan/upstream-issues/WR-697--addendum-2026-11-02-end-rail-rollover.md.

Related fork commits. Builds on the port of the fork's smooth-vertex End (smlib#124, #2364). Solidcore-native: the fork has no commit for it.

Fork status. tangency-labs/smlib#98 is open; at 18e96f1 CalcEndCapEdges still refuses "a rail rolling over into an end".

To reconcile. If the fork later builds this case: compare the two approaches (in particular the tangent rollover rule in sm_FindRolloverSideEdge, which this widens), keep one, and fold this into the port of the fork's fix or retire it.

Written by Claude Code (Anthropic) on behalf of @brett19.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions