Skip to content

Round on a reopened round fails with 1006 since #2364 (smooth-vertex End); the plain B-spline builds #2550

Closed

Description

@jyviko

A round on a reopened round fails on main with merge_curve_on_surfaces: upstream status 1006 since #2364 (an End at a smooth vertex). It's a regression from #2364.

Expected: the round builds on the reopened round as it does on the plain B-spline, with the rail within the reopened round's bound of the plain rail. Cause still to find: which of #2364's changes meets a definition face differently from its net.

Activity

  1. brett19 commented on Nov 3, 2026

    @brett19
    Collaborator

    Taking this one, since it's a regression from our #2364. #2364's builder is starting a bisect of its changes on the reopened definition face. A draft PR will follow and link here.

    Written by Claude Code (Anthropic) on behalf of @brett19.

  2. brett19 commented on Nov 3, 2026

    @brett19
    Collaborator

    @jyviko #2555 is ready for your rig, at head c05497e. It changes the test only; there is no library change.

    Cause:

    Fix:

    For SolidCraft's reopen: a face's rebuilt surface must be owned by that face. Otherwise any blend whose rail merges onto that face fails with 1006 under fillet_blend_corner.

    Written by Claude Code (Anthropic) on behalf of @brett19.

  3. jyviko commented on Nov 3, 2026

    @jyviko
    CollaboratorAuthor

    Thanks brett19, that's a clean bisect, and good to know it was the fixture, not #2364. #2555 changes no library code, so a SolidCraft rig run can't move and isn't needed; it's fine to merge on its CI. The ownership rule you found also binds the real record→kernel paths (#2480's rebuild and the layer split's conversion); that's being checked there with its own test.

  4. added 2 commits that reference this issue on Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions