Repository navigation
findings: smlib#120's warning fixes checked against the port, none changes it (#2362) - #2391
Merged
bherbruck merged 2 commits intoNov 2, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…y-labs#2362) The fork's 9846aa0 fixes the USD build's 19 warnings at 18 sites. Each is mapped to its Rust counterpart: none needs a change. The two real defects are a dump the port does not have (delete for new[]) and a constant text the port never uses as a format; the refusal texts the C++ now bounds to 200 characters insert at most 36, so they read the same in both. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
khanahmad4527
marked this pull request as ready for review
November 2, 2026 14:07
bherbruck
approved these changes
Nov 2, 2026
bherbruck
left a comment
Collaborator
There was a problem hiding this comment.
Approved by the automated first-pass review: CI green, mergeable, no CI/build/dependency file changes, no red-flag patterns in added code (process/network/env/unsafe outside FFI/blobs/hidden unicode), 0 known-mismatch entries added. Logic is gated by CI and the difftest merge queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2362.
tangency-labs/smlib#120 (e8cf987) makes SMLib compile clean under the USD build's warning flags; its fixes are commit 9846aa0, 19 warnings at 18 sites. I checked each site against its Rust counterpart. None needs a code change, so this PR is the record only:
plan/findings/general--smlib-120-warning-fixes-checked-against-the-port.md, which maps every site (C++ file and function, Rust path and line, verdict).SmBlendCornerconstructor); null-compare on a reference (SmBallPatch,SmProceduralBlendoperator==); the seven-Wshadow=localrenames (ExactMitreCurve,BallCentre,EvaluateDefinition,sm_DraftSeamPcurve, bothCreateFilletBreploops); the-Wswitchcase (the Rustmatchhas a do-nothing_arm); the unusediDebugLevel(not ported); the refusal text passed as a format; the two%.200sbounds; the dead four-argumentsm_HermitePointsmainSmCrvInVolume::Dump(thedelete []fix),kf_InMaterial(dead in the fork, never ported),sm_SbGraphG1(the setback corner, open as #2369, which keeps the term as a struct field, so it has no shadowing to fix), theSmBallPatchclassThe two real defects. The
deletefornew[]is in a debug dump the port does not have, and Rust frees by ownership. The refusal text used as a format is a constant with no%, so the C++ printed it correctly before the fix too, and the Rust builds the same text withto_string().Refusal texts. The fix bounds the inserted text to 200 characters in two
NoRoommessages. That text is": a radius below <%.7g> fits"or": no smaller ball fits there either", 36 characters at most, so the C++ messages are unchanged, andblend/fillet_executive/p3.rs:3491and:3496build the same text withformat!. No message or result changes, so nothing is opt-in under section 4b.Follow-up (not done here).
blend/fillet_section/form.rs'shermite_pointsis the Rust copy of the four-argumentsm_HermitePointsthe fork deleted; only its own test calls it. Removing it and pointing that test athermite_points_sidedwould keep the file in step with the fork. It has no effect on results.Checks:
scripts/ci/check_record_ids.pyandscripts/ci/check-frozen-archives.shpass. No Rust source changed, so no build or test run was needed.