Conversation
shekohex
requested changes
Feb 2, 2024
Co-authored-by: shekohex <dev+github@shadykhalifa.me>
drewstone
force-pushed
the
drew/zcashfrost
branch
from
e4fe57f to
0369386
Compare
Contributor
Author
|
OK I updated the README here too @tbraun96, still stuck on same issue w/ message ordering |
…gadget into drew/zcashfrost
shekohex
requested changes
Feb 28, 2024
Comment on lines
+39
to
+61
| /// Message from round 1 | ||
| #[derive(Clone, Serialize, Deserialize, udigest::Digestable)] | ||
| #[serde(bound = "")] | ||
| #[udigest(bound = "")] | ||
| #[udigest(tag = "zcash.frost.keygen.threshold.round1")] | ||
| pub struct MsgRound1 { | ||
| pub msg: Vec<u8>, | ||
| } | ||
| /// Message from round 2 | ||
| #[derive(Clone, Serialize, Deserialize, udigest::Digestable)] | ||
| #[serde(bound = "")] | ||
| #[udigest(bound = "")] | ||
| #[udigest(tag = "zcash.frost.keygen.threshold.round2")] | ||
| pub struct MsgRound2 { | ||
| pub msg: Vec<u8>, | ||
| } | ||
| /// Message from round 3 | ||
| #[derive(Clone, Serialize, Deserialize)] | ||
| #[serde(bound = "")] | ||
| pub struct MsgRound3 { | ||
| pub msg: Vec<u8>, | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
We should start thinking about moving away from vec and start using actual message structure here.
Contributor
Author
There was a problem hiding this comment.
Yes, we'll need to generalize over the C: CipherSuite which unfortunately was causing me issues sharing between threads.
…into drew/zcashfrost
Co-authored-by: shekohex <dev+github@shadykhalifa.me>
Co-authored-by: shekohex <dev+github@shadykhalifa.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.