feat: sort snapshot tags alphabetically in listSnapshots() - #21
Open
vivekyadav-3 wants to merge 2 commits into
Open
feat: sort snapshot tags alphabetically in listSnapshots()#21vivekyadav-3 wants to merge 2 commits into
vivekyadav-3 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes listSnapshots() return snapshot tags in a deterministic order by sorting them alphabetically before returning, ensuring stable output across OS/filesystem differences.
Changes:
- Sorts the array of snapshot tags A→Z in
listSnapshots()by adding.sort()to the return chain.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .readdirSync(SNAP_DIR) | ||
| .filter((f) => f.endsWith(".json")) | ||
| .map((f) => f.replace(".json", "")); | ||
| .map((f) => f.replace(".json", "")) |
Author
|
Hi @tanmayjoddar, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6
listSnapshots()was returning snapshot file tags in whatever orderthe OS filesystem provided — which is non-deterministic and differs
between Linux, macOS, and Windows.
Changes
src/storage/snapshotStore.js: Added.sort()to the end of thelistSnapshots()return chainBefore / After
v2.0, main, beta, v1.0(random OS order)beta, main, v1.0, v2.0(stable A→Z)Notes
.sort()uses locale-independent lexicographic ordering by defaultv1.0.13continue to work unchangednpm testpasses ✅