Make encore compatible with react-native 76 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using react-native 76 (Expo 52) and shadow-cljs, js/window hangs in the REPL -- it does not return nil. This causes the UUID code to fail.
hadils
pushed a commit
to hadils/sente
that referenced
this pull request
Nov 18, 2024
Using react-native 76 (Expo 52) and shadow-cljs, js/window hangs in the REPL -- it does not return nil. This causes the UUID code to fail. Added react-native-target? to check for this. Also turned off event listener code for RN. Uses a version of encore that has been submitted as a pull request. See taoensso/encore#80
ptaoussanis
added a commit
that referenced
this pull request
Nov 19, 2024
|
@hadils Thanks a lot for this Hadil! 🙏 I've just pushed Encore v3.132.0 to Clojars which includes your changes. I'll update Sente when I'm next on batched Sente work for v1.20 final. In the meantime you can manually include the latest Encore in your project. If using Leiningen, just make sure that you place the Encore dependency before any other dependencies that might try pull in their own (older) version. Cheers! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using react-native 76 (Expo 52) and shadow-cljs, js/window hangs in the REPL -- it does not return nil. This causes the UUID code to fail.
Ran CLJ and CLJS unit tests
Tested RN on my set up. I did not create a test harness for RN