Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare-workspace: make an empty commit for actions/checkout #30

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

NickVolynkin
Copy link
Contributor

@NickVolynkin NickVolynkin commented Nov 10, 2022

Make an empty detached commit for actions/checkout to properly clean the project's workspace before checking out new code revision.

Part of #28
Related to tarantool/tarantool-qa#145

Readme preview: https://github.com/tarantool/actions/blob/nickvolynkin/cleanup-with-empty-commit/prepare-checkout/README.md

@NickVolynkin NickVolynkin force-pushed the nickvolynkin/cleanup-with-empty-commit branch from 0f14e8d to 8e2b4c8 Compare November 10, 2022 10:42
@NickVolynkin NickVolynkin marked this pull request as ready for review November 10, 2022 10:42
@NickVolynkin NickVolynkin force-pushed the nickvolynkin/cleanup-with-empty-commit branch from 8e2b4c8 to 83ea8fe Compare November 10, 2022 11:02
cleanup/README.md Outdated Show resolved Hide resolved
cleanup/README.md Show resolved Hide resolved
cleanup/README.md Outdated Show resolved Hide resolved
cleanup/README.md Outdated Show resolved Hide resolved
cleanup/README.md Outdated Show resolved Hide resolved
cleanup/README.md Outdated Show resolved Hide resolved
cleanup/README.md Outdated Show resolved Hide resolved
cleanup/action.yml Outdated Show resolved Hide resolved
cleanup/action.yml Outdated Show resolved Hide resolved
cleanup/action.yml Outdated Show resolved Hide resolved
@ylobankov
Copy link
Contributor

ylobankov commented Nov 10, 2022

Honestly, your change looks like a separate action that should be named prepare-workspace or prepare-checkout. If we form it as a separate action, it will be very easy to test and smoothly integrate it in all our workflows.

@NickVolynkin NickVolynkin force-pushed the nickvolynkin/cleanup-with-empty-commit branch from 83ea8fe to 0c91fb7 Compare November 10, 2022 12:32
@NickVolynkin NickVolynkin force-pushed the nickvolynkin/cleanup-with-empty-commit branch 5 times, most recently from 1297063 to c4339de Compare November 10, 2022 13:26
Copy link
Contributor

@ylobankov ylobankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prepare-checkout/action.yml Show resolved Hide resolved
prepare-checkout/action.yml Outdated Show resolved Hide resolved
Make an empty detached commit for actions/checkout to properly
clean the project's workspace before checking out new code
revision. It makes the actions/checkout resilient to
various problems related to git submodules.

Part of #28
Related to tarantool/tarantool-qa#145
@NickVolynkin NickVolynkin force-pushed the nickvolynkin/cleanup-with-empty-commit branch from c4339de to ba2fcf5 Compare November 10, 2022 13:32
@NickVolynkin NickVolynkin merged commit 9aba818 into master Nov 10, 2022
@NickVolynkin NickVolynkin deleted the nickvolynkin/cleanup-with-empty-commit branch November 10, 2022 13:34
@ylobankov ylobankov changed the title cleanup: make an empty commit for actions/checkout prepare-workspace: make an empty commit for actions/checkout Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants