cartridge: fix discovery to avoid missing aliases #1203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
4 times, most recently
from
8c8d7bd to
d5d0567
Compare
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
from
d5d0567 to
f42d50a
Compare
patapenka-alexey
approved these changes
Sep 4, 2025
oleg-jukovec
approved these changes
Sep 4, 2025
oleg-jukovec
reviewed
Sep 4, 2025
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
4 times, most recently
from
20114aa to
c888519
Compare
oleg-jukovec
approved these changes
Sep 4, 2025
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
7 times, most recently
from
eb571b8 to
132adc1
Compare
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
3 times, most recently
from
177ed43 to
96bb340
Compare
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
from
96bb340 to
31fa5fb
Compare
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
6 times, most recently
from
15d0303 to
eb81b99
Compare
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
7 times, most recently
from
9e6410b to
f4c8402
Compare
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
from
f4c8402 to
9c3b3c8
Compare
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
from
9c3b3c8 to
cb3f1e1
Compare
elhimov
changed the title
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
from
cb3f1e1 to
e890680
Compare
Implementation of cartridge bootstrap in `tt` needs to know aliases of all instances to work properly. Aliases of instances are managed with `membership` module which spreads out certain instance alias across the rest of instances using `gossip` protocol. At the very start of an instance only that instance "knows" its alias, others get this knowledge with some delay. That means in turn that the topology obtained from the different instances might differ in terms of aliases. Prior to this patch topology from a single instance was used and if at that moment this instance haven't collected information about all the aliases, bootstrap failed. Now if any alias is missing we are trying to get it from the topologies obtained from the other instances until all aliases are resolved. The patch fixes flaky test so there is not need to introduce new tests. Closes #TNTP-3709
elhimov
force-pushed
the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
from
e890680 to
cdc3361
Compare
oleg-jukovec
approved these changes
Sep 25, 2025
patapenka-alexey
approved these changes
Sep 25, 2025
dmyger
deleted the
elhimov/tntp-3709-flaky-test_replicaset_bootstrap_cartridge_app_second_bootstrap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of cartridge bootstrap in
ttneeds to know aliases of all instances to work properly. Aliases of instances are managed withmembershipmodule which spreads out certain instance alias across the rest of instances usinggossipprotocol. At the very start of an instance only that instance "knows" its alias, others get this knowledge with some delay. That means in turn that the topology obtained from the different instances might differ in terms of aliases.Prior to this patch topology from a single instance was used and if at that moment this instance haven't collected information about all the aliases, bootstrap failed. Now if any alias is missing we are trying to get it from the topologies obtained from the other instances until all aliases are resolved.
The patch fixes flaky test so there is no need to introduce new tests.
I didn't forget about:
Related issues:
Closes TNTP-3709