Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff workflow #2660

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add ruff workflow #2660

wants to merge 5 commits into from

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Jun 17, 2024 •
edited
Loading

馃摑 Description

Adds a ruff job alongside black.

馃搶 Resources

Examples, notebooks, and links to useful references.

馃殾 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

鈽戯笍 Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@atharva-2001 atharva-2001 marked this pull request as ready for review June 17, 2024 07:57
andrewfullard
andrewfullard requested changes Jun 21, 2024
View reviewed changes
.github/workflows/codestyle.yml Show resolved Hide resolved
.github/workflows/codestyle.yml Outdated Show resolved Hide resolved
wkerzendorf
wkerzendorf reviewed Jun 26, 2024
View reviewed changes
.github/workflows/codestyle.yml
python-version: '3.12.3'

- name: Install Ruff
run: pip install ruff==0.4.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkerzendorf wkerzendorf wkerzendorf left review comments

@andrewfullard andrewfullard andrewfullard approved these changes

@Knights-Templars Knights-Templars Awaiting requested review from Knights-Templars

@KasukabeDefenceForce KasukabeDefenceForce Awaiting requested review from KasukabeDefenceForce

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
codestyle
Projects
DevOps
Status: waiting for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atharva-2001 @wkerzendorf @andrewfullard @KasukabeDefenceForce @Knights-Templars