Solution refactor #211
Merged
Solution refactor #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tareqimbasher
force-pushed
the
solution-refactor
branch
from
e2204dd
to
219d6df
Compare
tareqimbasher
force-pushed
the
solution-refactor
branch
4 times, most recently
from
d9096a9
to
ca5613c
Compare
When I started this project I knew I wanted to work towards these minimum requirements: 1. Must support Windows, macOS and Linux 2. Must support at least .NET 6 or higher 3. Must run with as little hassle as possible for end users. I initially took a layered approach to structuring the solution, this helped me clearly understand the different components, abstractions and dependencies that will make up the app during development. Its time for a simpler structure however that's easier to understand and maintain. This restructure aims to: 1. Make the solution easier to maintain by reducing separation between components and bringing more related functionality together. 2. Make the solution easier to review by the community and easier to understand and contribute to. I plan to add documentation explaining the high level concepts and structure of the solution to help facilitate review and contribution. Some notable technical changes: - Reduced number of projects. Most of the core functionality of NetPad is now in a new NetPad.Runtime project - The concept of a "ScriptRuntime" is now called a "ScriptRunner" and is part of the "Execution Model" - Use Directory.Build.props file and C# 12 features - No refactoring was done to the JS app - Fix web version 'process' pollyfill - Passing --swagger flag to NetPad.Apps.App generates Swagger client code Refactoring that is also planned soon: - Refactoring of the JS app - Changing the name of the NetPad.Apps.App project and the folder containing the JS client app, currently named "App"
tareqimbasher
force-pushed
the
solution-refactor
branch
from
ca5613c
to
57d650f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution restructure
When I started this project I knew I wanted to work towards these high-level minimum requirements:
However I had yet to figure out how the pieces will fall on the board. I initially took a layered approach to structuring the solution, this helped me clearly understand the different components, abstractions and dependencies that will make up the app during development. That has now served its purpose, and its time for a simpler structure that's easier to understand and maintain. This restructure aims to:
I plan to add documentation explaining the high level concepts and structure of the solution to help facilitate review and contribution.
Some notable technical changes:
Refactoring that is also planned soon: