chore: consolidate visibility settings - #496
Open
EricEzaM wants to merge 2 commits into
Open
Conversation
EricEzaM
force-pushed
the
consolidate-visibility
branch
3 times, most recently
from
April 15, 2026 06:16
4d2a801 to
0c0943d
Compare
Collaborator
|
Is this one meant to still be in Draft? |
EricEzaM
marked this pull request as ready for review
April 20, 2026 23:00
Contributor
Author
|
Yeah, should be ready now |
Collaborator
|
Seems to be some issues around saving? [saveDashboard] Dashboard unchanged, not saving Also toggling any of the session options also toggles off all of the others? |
Contributor
Author
|
Fixed now. Although typescript is used, there are still many places that use untyped objects or |
* Create new property on DashboardWidget specifically for visibility configuration * Remove visibility code from individual widgets, move it to parent component which handles visibility. * Simplify settings widgets now that visibility settings are common on DashboardWidget.
EricEzaM
force-pushed
the
consolidate-visibility
branch
from
April 22, 2026 23:47
56c7dd3 to
6316805
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
Should be no changes to UI or behaviour.
Type of Change
Checklist
npm testnpm run lintand fixed any issues