Skip to content

chore: consolidate visibility settings - #496

Open
EricEzaM wants to merge 2 commits into
tariknz:mainfrom
EricEzaM:consolidate-visibility
Open

chore: consolidate visibility settings#496
EricEzaM wants to merge 2 commits into
tariknz:mainfrom
EricEzaM:consolidate-visibility

Conversation

@EricEzaM

Copy link
Copy Markdown
Contributor

Description

  • Create new property on DashboardWidget specifically for visibility configuration
  • Remove visibility code from individual widgets, move it to parent component which handles visibility.
  • Simplify settings widgets now that visibility settings are common on DashboardWidget.

Screenshots

Should be no changes to UI or behaviour.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Performance improvement
  • Refactoring (no functional changes)
  • Documentation update
  • Dependency update

Checklist

  • I have discussed this change in the discord server
  • I have tested this in iRacing (either in an online session or with AI)
  • All tests pass locally via npm test
  • I have added tests that prove my fix is effective or that my feature works
  • I have run npm run lint and fixed any issues
  • I have performed a self-review of my own code
  • I have added/updated Storybook stories for visual changes
  • I have updated the README.md (if applicable)
  • I have updated defaultDashboard.ts if introducing new widgets or configurations (if applicable)

@EricEzaM
EricEzaM force-pushed the consolidate-visibility branch 3 times, most recently from 4d2a801 to 0c0943d Compare April 15, 2026 06:16
@23Kev

23Kev commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Is this one meant to still be in Draft?

@EricEzaM
EricEzaM marked this pull request as ready for review April 20, 2026 23:00
@EricEzaM

Copy link
Copy Markdown
Contributor Author

Yeah, should be ready now

@spikethedog78

Copy link
Copy Markdown
Collaborator

Seems to be some issues around saving?

[saveDashboard] Dashboard unchanged, not saving

Also toggling any of the session options also toggles off all of the others?

@EricEzaM

Copy link
Copy Markdown
Contributor Author

Fixed now. Although typescript is used, there are still many places that use untyped objects or Record<string, unknown> which may as well be untyped. As a result, I missed adding visibilityConfig to a couple of places where saving happens.

* Create new property on DashboardWidget specifically for visibility configuration
* Remove visibility code from individual widgets, move it to parent component which handles visibility.
* Simplify settings widgets now that visibility settings are common on DashboardWidget.
@EricEzaM
EricEzaM force-pushed the consolidate-visibility branch from 56c7dd3 to 6316805 Compare April 22, 2026 23:47
@tariknz tariknz changed the title Consolidate visibility settings chore: Cconsolidate visibility settings May 10, 2026
@tariknz tariknz changed the title chore: Cconsolidate visibility settings chore: consolidate visibility settings May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants