Add PyPy support #401
Draft
Add PyPy support #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This would PREVENT conflicts that would otherwise arise if PyPy
copies PEP 528 per se.
- This would also NOT conflict if PyPy copies "our" solution
instead of PEP 528.
- This COULD cause conflicts if PyPy comes up with its own,
completely independent fix, if that fix keeps console I/O as a
subclass of `io.FileIO`.
- In any case, a guard like
and not (platform.python_implementation() == 'PyPy' and sys.pypy_version_info >= (8,0))
should be appended to the existing CPython version check when the
time comes.
Emoji being silently eaten by the CMD App window is arguably far better than killing the whole program because print() choked...
|
I think this is ready to merge, would appreciate any feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows CMD still uses Codepage 437 for regular I/O by default.
However, PyPy currently tries to treat it as UTF-8.
This pull request should fix that, making the
just_fix_windows_consolefunction even better.Is this something you'd be interested in?