make types better #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
and also add search and first top, lemem know if you want me to split these into separate prs |
auscyber
force-pushed
the
main
branch
5 times, most recently
from
3f91e2d
to
facd4db
Compare
|
okay now im actually actually done, i just messed up a lot of the like blame and consistency with the commits, like it seemed like i made way more changes than i did, all good now :3 |
Add more routes, make tests better make types more comprehensive
|
Looks like the checks in actions are failing. Ill have a look at this soon and get this merged in :3 . Thank you for the pr !! this is wonderful |
|
looks like the tests broke or something, error said devid wrong, it worked for me on my repo |
|
like u can see the tests on my push, maybe ur devid got invalidated? |
|
Tests worked locally? Ill get this working in the ci |
|
Also will do a fmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is reasonably sane? I don't have access to the API's so I haven't tested it, but it should be right if i've flattened everything correctly.
derive_moreis to make all the Display implementations a bit simplerand also sorry it is a lot of code