ci: skip node:sqlite adapter tests on Node < 22.13 - #575
Merged
Conversation
The Android fallback tests open a node:sqlite database, which does not exist on the Node 20 CI matrix leg (ERR_UNKNOWN_BUILTIN_MODULE). Probe for the built-in module and skip those tests when absent; the factory-selection test still runs everywhere. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing CI run on main. The Android-fallback tests added in #573 open a
node:sqlitedatabase, but the built-in module only exists in Node 22.13+ — the Node 20 matrix leg failed withERR_UNKNOWN_BUILTIN_MODULE.The test file now probes for the module via
createRequireand skips the three database-opening tests when it's absent; the factory-selection test still runs on every Node version. Verified locally: 4/4 on Node 24, typecheck clean.