Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue #116 #117

Merged
merged 4 commits into from
Dec 30, 2023
Merged

Fix to issue #116 #117

merged 4 commits into from
Dec 30, 2023

Conversation

kaidaniel82
Copy link
Contributor

@kaidaniel82 kaidaniel82 commented Dec 21, 2023

Description

Related issue(s)

Fixes ...

Pre-merge checklist

  • Passing tests LOCALLY
  • New tests added (if applicable)

Please note that, in order to pass the tests, you'll need to set up your Tastytrade credentials as repository secrets on your local fork. Read more at CONTRIBUTING.md.

Copy link
Contributor

@Graeme22 Graeme22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small thing.

tastytrade/account.py Outdated Show resolved Hide resolved
@kaidaniel82
Copy link
Contributor Author

Done

@kaidaniel82
Copy link
Contributor Author

What is the next step? I never did a pull request before? Ar you going to release this now?

@Graeme22 Graeme22 merged commit f12e4a4 into tastyware:master Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants