Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instruments.py #192

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Update instruments.py #192

merged 2 commits into from
Jan 12, 2025

Conversation

Quenos
Copy link
Contributor

@Quenos Quenos commented Jan 10, 2025

get_chain now returns a list with all chains

Description

Related issue(s)

Fixes #191

Pre-merge checklist

  • Code formatted correctly (check with make lint)
  • Code implemented for both sync and async
  • Passing tests locally (check with make test, make sure you have TT_USERNAME, TT_PASSWORD, and TT_ACCOUNT environment variables set)
  • New tests added (if applicable)

Please note that, in order to pass the tests, you'll need to set up your Tastytrade credentials as repository secrets on your local fork. Read more at CONTRIBUTING.md.

Quenos and others added 2 commits January 10, 2025 17:55
get_chain now returns a list with all chains
Copy link
Contributor

@Graeme22 Graeme22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Graeme22 Graeme22 merged commit a2d9ce2 into tastyware:master Jan 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NestedOptionChain.get_chain and NestedOptionChain.a_get_chain not returning complete chain
2 participants