feat(single-instance): add logging when closing a 2nd instance #2995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think we should do the same for other platforms as well? (you can find them from std::process::exit(0) calls)
Also do you mind also adding a change file?
https://github.com/tauri-apps/plugins-workspace/blob/v2/.changes/readme.md
| ), | ||
| ); | ||
| } | ||
| tracing::info!( |
There was a problem hiding this comment.
We probably want tochange this to debug level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a Tauri app which was crashing on startup, I got into a state where every time I opened the app, it would close unexpectedly with exit code 0. I had to open
gdb,break exitand usebtto figure out that it was actually Tauri closing the app due to thesingle-instanceplugin. I had a zombie process taking the DBusSingleInstancename for my app.This PR adds a
tracing::infomessage whenexit(0)ing the app on Linux if the single instance DBus name is already taken.