fix(single-instance): use a proper background thread to accept and receive unix socket streams #3037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceive unix socket streams
Package Changes Through c749627There are 10 changes which include deep-link with patch, deep-link-js with patch, fs with patch, fs-js with patch, geolocation with patch, geolocation-js with patch, opener with patch, opener-js with patch, updater with minor, updater-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
Thanks for the PR! Would you mind adding a very small changefile like this as well please? https://github.com/tauri-apps/plugins-workspace/blob/85c83dd2a6ad6e52159ad0dbd1d33b8e6540d3bd/.changes/enhance-fs-error-message.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this has blocked a whole tokio worker thread. Causing issues with task wakeups etc. We should never use blocking i/o operations inside an async task, that's why this PR moves that logic to a separate background thread. Alternatively we could still utilize an async thread but we'd have to use the async aware UnixListener and co. which would require us to pull in a whole async runtime in.
(There are still some things unknown to me because technically tokio should've been able to schedule the task on a different worker thread due to work stealing. But tokio-console shows that the hung task is still stuck in scheduling. EDIT: Ah I think this behavior I am seeing might be the lifo optimization and it being non-stealable)