fix: macOS automatic help menu detection #14199
Conversation
Package Changes Through c887d04There are 9 changes which include @tauri-apps/api with minor, tauri-cli with minor, tauri-utils with minor, tauri-runtime-wry with minor, tauri-runtime with minor, tauri with minor, tauri-bundler with minor, @tauri-apps/cli with minor, tauri-macros with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| #[cfg(not(target_os = "macos"))] | ||
| &PredefinedMenuItem::about(app_handle, None, Some(about_metadata))?, | ||
| ], | ||
| &[&PredefinedMenuItem::about( |
There was a problem hiding this comment.
On macOS the About stuff is already in the first menu item (the one with the appname as label)
There was a problem hiding this comment.
I didn't change anything there. I assume it's there kinda just to have something in there (looks weird otherwise)
There was a problem hiding this comment.
Oh nvm I'm stupid, I did change it. Well yeah, I think it's best to have something there
There was a problem hiding this comment.
Electron's default menubar has Electron's own links in there, that's an option
There was a problem hiding this comment.
i agree that it looks weird without anything (at least as far as i can remember, didn't see check for ages)
There was a problem hiding this comment.
It actually doesn't look that weird on macos 26 anymore with all that added padding. Can we perhaps still revert this part? I'm completely on board with the hotfix of the actual issue so i'd like to get it in asap but i think what we put into the help menu needs a bit more thinking since right now it's only added for visuals.
Electron's default menubar has Electron's own links in there, that's an option
Actually not a fan of that at all since it basically forces everyone to create their own menu even if they want just the default (cause they actually don't want a menu at all in the context of windows/linux)
| // { | ||
| // let resources_table = webview.resources_table(); | ||
| // let submenu = resources_table.get::<Submenu<R>>(rid)?; | ||
| // submenu.set_as_help_menu_for_nsapp()?; |
There was a problem hiding this comment.
we're also calling it incorrectly here:
tauri/crates/tauri/src/menu/plugin.rs
Line 814 in 4188ffd
Fixes #13605
By default, macOS auto-detects the
Helpsubmenu and adds a search bar to it. But since muda'sset_as_help_menu_for_nsappis broken (tauri-apps/muda#263), the search bar would never show at for any app ever - So I've disabled that code for the time being.