Skip to content

Conversation

@FabianLars
Copy link
Member

No description provided.

@FabianLars FabianLars requested a review from a team as a code owner November 3, 2025 12:24
@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Nov 3, 2025
.map(|alt_url| (ureq::agent(), alt_url))
.map(|alt_url| {
(
ureq::Agent::config_builder()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to add the platform certs here as well but nobody complained so far so idk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use base_ureq_agent here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assumed that setting the proxy may be a bad idea here. but idk i just kept it as-is cause i wasn't involved in that part at all and idk the requirements or expectations.

Copy link
Contributor

@Legend-Master Legend-Master Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's go with this for now and see if anyone using it actually wants to change this

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Package Changes Through ccb47ad

There are 3 changes which include tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.7.2 2.7.3
@tauri-apps/cli 2.9.2 2.9.3
tauri-cli 2.9.2 2.9.3

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

.map(|alt_url| (ureq::agent(), alt_url))
.map(|alt_url| {
(
ureq::Agent::config_builder()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to use base_ureq_agent here?

@FabianLars FabianLars merged commit 22edc65 into dev Nov 4, 2025
17 checks passed
@FabianLars FabianLars deleted the bundler-user-agent branch November 4, 2025 09:53
@github-project-automation github-project-automation bot moved this from 📬Proposal to 🔎 In audit in Roadmap Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In audit

Development

Successfully merging this pull request may close these issues.

3 participants