-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix(bundler/cli): set user-agent when fetching build tools #14408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| .map(|alt_url| (ureq::agent(), alt_url)) | ||
| .map(|alt_url| { | ||
| ( | ||
| ureq::Agent::config_builder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may want to add the platform certs here as well but nobody complained so far so idk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use base_ureq_agent here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i assumed that setting the proxy may be a bad idea here. but idk i just kept it as-is cause i wasn't involved in that part at all and idk the requirements or expectations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's go with this for now and see if anyone using it actually wants to change this
Package Changes Through ccb47adThere are 3 changes which include tauri-bundler with patch, tauri-cli with patch, @tauri-apps/cli with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| .map(|alt_url| (ureq::agent(), alt_url)) | ||
| .map(|alt_url| { | ||
| ( | ||
| ureq::Agent::config_builder() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to use base_ureq_agent here?
No description provided.