Fixed bug #61 (Parser hangs on some input) #62
Closed
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default chunk size of 5 is slow with large inputs
kirbysayshi
pushed a commit
to kirbysayshi/node-htmlparser
that referenced
this pull request
Dec 19, 2013
fixes tautologistics#62 apparently Google's gumbo-parser does behave this way: https://github.com/google/gumbo-parser/blob/101726c50e172e45be6002c51b85 e45f27f0c2c6/src/tokenizer.c#L322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug #61 (Parser hangs on some input).
The bug is caused by
_reTagName(/^\s*(\/?)\s*([^\s\/]+)/) doing too much backtracking when the input string contains many whitespaces.