Minor portability improvements #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- support BSD tar(1) - support BSD install(1) - remove dependency on working directory from binutils and gzip build scripts - explicit dependency on GNU make (gmake(1))
jserv
reviewed
Jun 8, 2022
binutils.sh
Outdated
| --disable-plugins \ | ||
| --disable-gprof \ | ||
| --enable-compressed-debug-sections=none && \ | ||
| gmake all-ld -j$(nproc) MAKEINFO=true |
There was a problem hiding this comment.
Command gmake is not found in default Ubuntu Linux installation even after running sudo apt install make. Can you specify the appropriate command (gmake or make) by detecting at runtime?
There was a problem hiding this comment.
Most certainly. Added a script to detect GNU make.
|
Note that FreeBSD port PR #86 should contain all the changes in this PR, so it can be merged instead, otherwise they should still merge cleanly on top of each other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tar(1)install(1)gmake(1))