Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: uploads.im is down. #7

Merged
merged 6 commits into from
Jan 27, 2018

Conversation

shadycuz
Copy link
Collaborator

Uploads.im is down. Probably for good. Returning 500 with no msg. Not just the API but the website as well. Fixes #6

I have signed up for a cloudinary free account under the "Octoprint-Twilio" Moniker. I can share the creds with you if you like.

Last time you updated the py package to 0.3.0 but did not set that in setup.py. I have the set the version in setup.py to 0.3.1.

Thanks,
Levi

@taxilian
Copy link
Owner

I've invited you as a collaborator on the project; I don't have a lot of time to work on this right now and you seem to know what you're doing =]

@taxilian taxilian merged commit 5e1dd4f into taxilian:master Jan 27, 2018
@shadycuz
Copy link
Collaborator Author

@taxilian I think you will still have to push the pypi releases.

Creating tar archive
removing 'OctoPrint-Twilio-0.3.1' (and everything under it)
running upload
Submitting dist/OctoPrint-Twilio-0.3.1.tar.gz to https://upload.pypi.org/legacy/
Upload failed (403): The user 'shadycuz' is not allowed to upload to project 'OctoPrint-Twilio'.

@taxilian
Copy link
Owner

Finally getting to this. I actually did bump the versions in setup.py, I just forgot to git push =] Easily disstracted, I guess.

I've made you a maintainer for the project on pypi; I'll try to remember how to submit this. I don't submit things to pypi very often (Just this, in fact) so I have to relearn each time.

@taxilian
Copy link
Owner

I think I figured it out, but next time you can do it yourself if you need =] At this point you've done as much original coding as I have.

Just as a point of interest, the main feature I've considered adding that I haven't yet is support for sending the text using a google voice account.

@shadycuz
Copy link
Collaborator Author

shadycuz commented Jan 28, 2018 via email

@taxilian
Copy link
Owner

https://github.com/pettazz/pygooglevoice

http://sphinxdoc.github.io/pygooglevoice/

I haven't played with it in awhile, but if I remember correctly you needed to do something to log in on the console and it'd save the creds in your home directory; after that it would all just work.

No reason we'd need to collect any information from people for this to work, the config would all be on their system.

@tedder
Copy link
Contributor

tedder commented Jan 29, 2018

Please don't remove the Twilio support when doing this.

@shadycuz
Copy link
Collaborator Author

shadycuz commented Jan 29, 2018 via email

@shadycuz
Copy link
Collaborator Author

@taxilian So I looked at the API. It doesn't support MMS, though we could still pass on the link to the person. We could implement MMS our selves and Submit a PR.

The real issue is how many people are using just voice? For instance my google voice is integrated with my google hangouts, so this new plugin would not work for me.

@taxilian
Copy link
Owner

... huh. are you sure? Granted, my main gvoice number I've been using since before it was owned by Google, back when it was GrandCentral, but even new accounts I've set up I can send and receive SMS messages through. I haven't tried all of them through the pygooglevoice API, though.

if you go to voice.google.com do you not have a phone number and such?

My thought was that if you didn't have google voice you could just set up a gvoice account, but this is the first inkling I've heard that it might not be compatible with some gvoice accounts.

@shadycuz
Copy link
Collaborator Author

@taxilian You can send MMS with google voice ;) but not with the python library. pettazz/pygooglevoice#50

I have a google voice number, but I can't use the google voice api to use it because I have it integrated into hangouts. I'm guessing most users will have it integrated into hangouts but that might be changing https://www.usatoday.com/story/tech/columnist/2017/01/29/best-android-messaging-apps-crowded-field/97155226/ . Any new accounts just for the new plugin would work fine.

image

@taxilian
Copy link
Owner

taxilian commented Jan 30, 2018

Interesting. I suspect that a lot of android users do that, but probably only them. Additionally, I would tend to lean towards making a google voice account just for this purpose rather than using an existing account -- but then, I use my google voice number as a "home phone" number that we give people.

Regardless, seems like it should be useful... particularly since my twilio trial has ended and I'm not sure it's worth paying for just for this.

@shadycuz
Copy link
Collaborator Author

shadycuz commented Jan 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants