Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ROCm linux support #154

Merged
merged 3 commits into from
Jun 2, 2024
Merged

feat: ROCm linux support #154

merged 3 commits into from
Jun 2, 2024

Conversation

newfla
Copy link
Contributor

@newfla newfla commented May 31, 2024

The PR introduces the support for building the library with rocm/hipblas support.
The following changes have been made:

  • Added hipblas feature flag to whisper-rs and whisper-rs-sys
  • ROCm install folder can be optionally specified by env::HIP_PATH. Defaults to /opt/rocm
  • Gpu targets can be optionally specified by env::AMDGPU_TARGETS
  • Panics when targeting windows

Unfortunately I wasn't able to build whisper.cpp on windows: generated vcxproj refuse to use hipcc and defaults to cl.exe 馃槪

@tazz4843 tazz4843 mentioned this pull request May 31, 2024
Cargo.toml Show resolved Hide resolved
README.md Show resolved Hide resolved
sys/build.rs Outdated Show resolved Hide resolved
@tazz4843 tazz4843 merged commit b46876a into tazz4843:master Jun 2, 2024
13 checks passed
@tazz4843
Copy link
Owner

tazz4843 commented Jun 2, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants