Editorial: remove some unnecessary "the result of" phrasing #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
reviewed
Jun 6, 2024
spec.html
Outdated
| @@ -9260,7 +9260,7 @@ <h1> | |||
| 1. If |ClassHeritage| is present, return *true*; otherwise return *false*. | |||
| 1. If |ClassHeritage| is present, then | |||
| 1. If |ClassHeritage| Contains _symbol_ is *true*, return *true*. | |||
| 1. Return the result of ComputedPropertyContains of |ClassBody| with argument _symbol_. | |||
| 1. Return ComputedPropertyContains of |ClassBody| with argument _symbol_. | |||
There was a problem hiding this comment.
This reads weirdly to me; I would much prefer to keep the previous form, here and in most of the cases involving an AO or SDO invocation below.
There was a problem hiding this comment.
Can you be more specific about which cases, or try to define a general rule?
syg
reviewed
Jun 21, 2024
spec.html
Outdated
| @@ -9214,7 +9214,7 @@ <h1> | |||
| 1. For each child node _child_ of this Parse Node, do | |||
| 1. If _child_ is an instance of _symbol_, return *true*. | |||
| 1. If _child_ is an instance of a nonterminal, then | |||
| 1. Let _contained_ be the result of _child_ Contains _symbol_. | |||
| 1. Let _contained_ be _child_ Contains _symbol_. | |||
There was a problem hiding this comment.
I like the old form better for Contains.
There was a problem hiding this comment.
Agreed, though I'm not a huge fan of using infix notation for Contains in the first place.
bakkot
reviewed
Jun 26, 2024
michaelficarra
force-pushed
the
the-result-of
branch
from
4b49663
to
0396d4b
Compare
bakkot
approved these changes
Jul 1, 2024
syg
approved these changes
Jul 9, 2024
michaelficarra
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns well with our editorial convention of avoiding "the value of".