Add tests for Joint Iteration proposal + split tests #4609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/built-ins/Iterator/zip/iterables-iteration-after-reading-options.js
Show resolved
Hide resolved
test/built-ins/Iterator/zipKeyed/results-object-has-default-attributes.js
Outdated
Show resolved
Hide resolved
test/built-ins/Iterator/zipKeyed/iterables-iteration-get-abrupt-completion.js
Show resolved
Hide resolved
michaelficarra
approved these changes
Nov 2, 2025
Member
michaelficarra
left a comment
michaelficarra
left a comment
There was a problem hiding this comment.
LGTM otherwise! Looks like this fully covers the test plan and then some. Thanks again @anba for writing these tests.
Member
|
FYI I've confirmed the latest diff with the polyfill from the proposal repo and it still passes. |
Contributor
|
This was written by someone involved in the implementation and reviewed by two proposal champions. I would be comfortable to merge it now, to avoid holding it up any further. I would prefer that in the future we are more strict with the "mini-polyfill" stuff but I personally won't have the bandwidth to propose an alternative, nor review the rest of the PR, in the near future. @gibson042 @ljharb @Ms2ger What do you think? |
Contributor
|
I would be okay with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all of the commits from #4528 plus one additional one to split tests per maintainer request there.