Temporal: Coverage for wrapping at the end of the month #4695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
requested changes
Nov 21, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks!
A few comments. I only reviewed the PlainDate tests closely, but AFAICS the comments apply to all the variations.
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-islamic-civil.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-indian.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-indian.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-islamic-civil.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-islamic-civil.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-islamic-civil.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-persian.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-persian.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-persian.js
Show resolved
Hide resolved
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-indian.js
Outdated
Show resolved
Hide resolved
ptomato
requested changes
Nov 24, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
One more request, thanks 😄
test/intl402/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month-persian.js
Show resolved
Hide resolved
ptomato
approved these changes
Nov 24, 2025
Covers Indian, Hijri, and Persian calendars
ptomato
force-pushed
the
wrapping-end-of-month-indian-hijri-persian
branch
from
764bf53 to
644a599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers Indian, Hijri, and Persian calendars