Omit extra newline when printing to stdout #730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconbeer
approved these changes
Nov 13, 2025
Owner
tconbeer
left a comment
tconbeer
left a comment
There was a problem hiding this comment.
This looks great, thank you. Just needs a CHANGELOG entry
swt30
force-pushed
the
omit-newline-stdout
branch
2 times, most recently
from
816ed66 to
a2c126f
Compare
Contributor
Author
|
There you go :) I guess this is technically a breaking change. Up to you to decide how you want to bump the version for release. |
Owner
|
No, this is fine. same as the tests you already changed. Just fix the tests, please |
Contributor
Author
|
Oh I see what you mean, there are extra end-to-end tests. I had only run |
swt30
force-pushed
the
omit-newline-stdout
branch
from
a2c126f to
ae6d184
Compare
Contributor
Author
|
All tests pass on my end 👍 |
swt30
force-pushed
the
omit-newline-stdout
branch
from
ae6d184 to
9d868a0
Compare
swt30
changed the title
swt30
force-pushed
the
omit-newline-stdout
branch
from
9d868a0 to
ddf760a
Compare
Contributor
Author
|
... and fix linter errors (sorry, I had missed there was a linter check too) |
delete extra coverage file
Contributor
Author
|
Thanks, sorry about accidentally including the coverage file, that was messy of me |
Owner
|
No worries! Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlfmt appends another newline to stdout when formatting text from stdin (as well as the newline added by the formatter).
This means that formatting outputs are inconsistent between the following methods:
This change removes the extra newline. It changes one test which assumed the existence of the extra newline, but I think this new behaviour makes more sense.
Fixes #729