use uniform sampling of bits #310
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements using the uniform sampling of this Plonky3 PR: Plonky3/Plonky3#1050
It gives an idea of the amount of code one needs to change. Essentially it's all about changing a lot of
GrindingChallengertraits toUniformGrindingChallenger. Aside from that it is just 3 lines (I think) to changesample_bitstosample_uniform_bits_may_panicandgrindtogrind_uniform_may_panic(where we use the overloads that may panic instead of doing rejection sampling).Feel free to look at this or wait until we actually decide if the above Plonky3 PR is even going to be merged at all. Things seem to work locally here at least.