dft: rm from public api #315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilic
reviewed
Oct 28, 2025
| folding_factor, | ||
| merkle_hash, | ||
| merkle_compress, | ||
| dft: Radix2DFTSmallBatch::<F>::default(), |
Contributor
There was a problem hiding this comment.
It becomes a bit faster on my end when we configure the fft instance like
let max_fft_size = num_variables + starting_rate - folding_factor.at_round(0);
let dft = Radix2DFTSmallBatch::<F>::new(1 << max_fft_size);
Owner
Author
There was a problem hiding this comment.
Yes you are right (I've the same locally), let us not merge this for now since we don't want to degrade performance for now, especially for such a detail.
I've another idea that would unblock things and would be to add a new method new(size:usize) inside this trait https://github.com/Plonky3/Plonky3/blob/658115aae28312e97cd3ef38d1ab046839f734a8/dft/src/traits.rs#L27. This would allow us to just rely on this and be able to init any DFT. Will check this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should supersede #314
@kilic what do you think about this?